Tweak JavaScript elements #186
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are private
TBD will be handled just after this It seems the only valuable option in opts is once (still not sure what `target` is)
I don't know where that one came from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm opening this as draft for you to keep track while I tweak (format, simplify, adapt, ...) our JavaScript elements. Best reviewed with
Hide whitespaceenabled.Hopefully, at the end, we'll have less code, and less "hackathon"-like, too 😄
I'll later (potentially) add self-review comments for pertinent changes, but since this is a "big one" it's maybe best you download the changes and perform comments directly where you think I was off 👍